search

dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
3.91k stars 102 forks source link

[BUG]: wrong anchor link in the website #649

Closed PerfectPan closed 1 week ago

PerfectPan commented 1 month ago

The website's anchor links appear to be incorrect, missing the original path, such as /blog/introducing-pages-router, as shown in the picture.

CleanShot 2024-04-04 at 23 03 40@2x

sandren commented 1 month ago

Thanks for reporting.

The root cause is an invalid <base> tag on nested routes: https://github.com/dai-shi/waku/blob/main/packages/waku/src/lib/plugins/vite-plugin-rsc-index.ts#L80

dai-shi commented 1 month ago

https://github.com/dai-shi/waku/blob/e8ca9ac9646dfb6b108c94832b68fc838bfeb1a0/packages/waku/src/lib/plugins/vite-plugin-rsc-index.ts#L78-L80

Yeah, I knew it wasn't the right solution. So, it's a framework issue. It may require someone's help. Help wanted.

Aslemammad commented 3 weeks ago

working on this!

dai-shi commented 1 week ago

by #697