dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
3.91k stars 102 forks source link

update react beta #671

Closed dai-shi closed 2 weeks ago

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Apr 25, 2024 11:06pm
codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dai-shi commented 3 weeks ago

All reds. Is this related to what @Tobbe said in the react repo?

himself65 commented 3 weeks ago

I feel like there is a module resolution issue somewhere var React = require('react'); is undefined

himself65 commented 3 weeks ago

Ok, I debug and SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE is in React but `CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE` is not, so at that moment, it returns react server code

dai-shi commented 3 weeks ago

Hm? Is there anything we can do then?

himself65 commented 3 weeks ago

I'm bisecting to see which commit caused this

himself65 commented 3 weeks ago
himself65 commented 3 weeks ago

OK, I made some changes in the React source code, and it works well. Not sure if this is an upstream issue... But I will open a draft to react repo

lazarv commented 2 weeks ago

Hi @dai-shi! I've found this issue and related PR at React while fixing and patching up my framework. My workaround was to register a node.js loader, where I change react/jsx-dev-runtime to react/jsx-runtime with react-server conditions. But I'm still working on resolving every breaking change React introduced since I created my initial version of my own framework. I was almost finished with the next version and the docs when I tried to upgrade to latest experimental React. Congrats for the release and keep up!

himself65 commented 2 weeks ago

Waiting for https://github.com/facebook/react/pull/28921 a new beta release

eps1lon commented 2 weeks ago

New Beta releases are automatically published every day around 4:15pm UTC