search

dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
3.91k stars 102 forks source link

test: add e2e tests for css modules #693

Closed negreirosleo closed 2 weeks ago

negreirosleo commented 2 weeks ago

This PR relates to #186. It adds e2e tests for CSS modules. I used expect .toContain('class-name') because I was not sure if the generated name would always be the same.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview May 4, 2024 5:33am
codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dai-shi commented 2 weeks ago

@himself65 Hi, would you be able to give a quick review please?

himself65 commented 2 weeks ago

@himself65 Hi, would you be able to give a quick review please?

btw, I was trying to add chromatic for visual test last year, forget to continue on this

dai-shi commented 2 weeks ago

Can you check CI errors? Are they understandable?

negreirosleo commented 2 weeks ago

Can you check CI errors? Are they understandable?

I'm checking it, but I'm having a different error on my machine: image

am I missing anything? I followed all the CONTRIBUTING.MD steps

dai-shi commented 2 weeks ago

Ah, you need to add a reference in tsconfig.e2e.json. If it works, feel free to improve CONTRIBUTING.md, thanks!

negreirosleo commented 2 weeks ago

I'm checking the final error so we can get this done

negreirosleo commented 2 weeks ago

LGTM, maybe we need to abstract e2e setup script so we don't need to copy paste everything

I can work on that if you want