dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
4.11k stars 108 forks source link

fix: do not crash whole server when error #738

Closed himself65 closed 3 weeks ago

himself65 commented 3 weeks ago

The main logic is ctx.res.body = stringToStream(${err});

Cleanup response stream when it raises an error because it's locked by react (how to release it?) otherwise hono server will crash

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jun 4, 2024 2:20am
codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

himself65 commented 3 weeks ago

I'm not sure how to reproduce the problem

Just throw new Error in side root server component

dai-shi commented 3 weeks ago

Well, I just count on you. Thanks for the fix!