search

dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
4.01k stars 104 forks source link

redesign the website completely #82

Closed ahme-dev closed 11 months ago

ahme-dev commented 11 months ago

This PR redesigns the website, based on the design here.

It will also create a prettierrc for unified formatting, and change tailwind colours to the ones used in the theme.

There are some issues currently:

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 8:24am
codesandbox-ci[bot] commented 11 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dbc7212598e13870a1b9361213d19f64986d1f50:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration
dai-shi commented 11 months ago

Thanks for your work!!

  • sidebar of docs does not highlight the page you're on (possibly solve using user requested url)

Ah, this is tricky. I need to think about it.

  • all icons are svg components (possibly better to have an 'assets' folder for storing svg as files)

It think 'assets' folder works. I haven't tried though.

  • original link component was restyled, but not sure whether to keep it or change into something else

I'll see what's changed.

ahme-dev commented 11 months ago

It now deploys correctly, so you can view it.

dai-shi commented 11 months ago

It now deploys correctly, so you can view it.

Cool! Looks great!

Here are some feedbacks:

dai-shi commented 11 months ago

https://github.com/dai-shi/waku/pull/82#discussion_r1242887384

Please remove .prettierrc.json file and add a "prettier" entry with empty config in package.json.

dai-shi commented 11 months ago
  • The logo looks a bit different. Can we use a similar font like the site?

It still remains.

  • I clicked the down arrow and nothing happened.

It still remains.

  • The dot loading indicator is nice and pretty (I like it) but it shows unnecessarily (some logic changed?)

Fixed, but in a hacky way.

It remains, but no easy solution yet.

I see a warning in console. Warning: validateDOMNesting(...): <pre> cannot appear as a descendant of <p>.

Please feel free to work on them and file follow-up PRs.

ahme-dev commented 11 months ago
  • I clicked the down arrow and nothing happened.

It still remains.

As far as I know, the only way to create a collapse menu is to use js, which I tried not to do. For now it can act as a heading.

dai-shi commented 11 months ago

For now it can act as a heading.

I thought it jumps to introduction, the same as Get Started > button does.

Merging it anyway.