search

daichirata / fluent-plugin-gcs

Google Cloud Storage output plugin for Fluentd.
Other
42 stars 19 forks source link

Migrate to use v0.14 API #6

Closed cosmo0920 closed 7 years ago

cosmo0920 commented 7 years ago

Hi, thanks for paying attention to use v0.14 Plugin API.

I've tried to migrate to use v0.14 Output Plugin API. This PR contains major update change. Could you bump up minor version if releasing new version of gem? And please refer http://docs.fluentd.org/v0.14/articles/plugin-update-from-v12 before release new version.

Thanks,

Will fix #5.

daichirata commented 7 years ago

@cosmo0920 Thank you for pull request and a good job! :tada:

I added some comments so please check it.

cosmo0920 commented 7 years ago

@daichirata I've tried to fix your comments. Could you take a look again?

cosmo0920 commented 7 years ago

Fixed.

daichirata commented 7 years ago

@cosmo0920 Thank you for fixing for fluentd v0.14! :confetti_ball::tada::sparkles: I will give you 100 github points :gift: :octocat:

Could you bump up minor version if releasing new version of gem?

OK, I will release the next version on v0.4.0.beta1.