makes scenario_20_training1 playable again for non-english-languages

daid / EmptyEpsilon

Open source bridge simulator. Build with the SeriousProton engine.

https://daid.github.io/EmptyEpsilon/

GNU General Public License v2.0

528 stars 179 forks source link

makes scenario_20_training1 playable again for non-english-languages #2095

Closed aBlueShadow closed 4 months ago

aBlueShadow commented 4 months ago

This addresses https://github.com/daid/EmptyEpsilon/issues/1686 and especially https://github.com/daid/EmptyEpsilon/issues/1686#issuecomment-1666091533 , as that scenario became unplayable for non-english languages.

This PR does not try to fix the actual issue (which seems to be very persistent) but offers a workaround, to make it at least playable again.

Deletes all database references, notably the ones that copy the ship names and cause the issue.
The custom ship name is transferred to the ship description for simple scan. So it now can be considered a description of how this particular ship is used, rather than an custom model name. Positive side effect: Other than ship names, this can safely be translated.

daid commented 4 months ago

I do wonder if there isn't just a simpler fix, where we say if ship_db == nil then return end. Which would make it the translated scenario doesn't have the DB entry and the base one does.

aBlueShadow commented 4 months ago

That would still leave 3 other errors on lines with setModelDataName, though.

daid commented 4 months ago

also fixable with nil checks, but I understand that that isn't great. I'll think a bit about it and most likely accept your pull request. The database modification from scripts are messy, so maybe having less of them is better right now.

aBlueShadow commented 4 months ago

Especially for that scenario, I don't see much benefit for those db modifications considering the problems. It is literally just the same ship with the same db entry just copied into the exuari category with another name. I am not sure if that feature is worth the hassle. And the custom typenames are very descriptive, so sourcing them out to the descriptions wouldn't be that bad IMO.