daifoundation / maker-otc

The OasisDEX protocol - Simple on-chain market for ERC20 tokens
GNU Affero General Public License v3.0
101 stars 39 forks source link

use separate events per function in SimpleMarket #152

Closed SCBuergel closed 5 years ago

SCBuergel commented 7 years ago

We should have separate events for offer, buy, cancel, trade, instead of reusing ItemUpdate in SimpleMarket.

nmushegian commented 7 years ago

https://github.com/makerdao/maker-otc/pull/155

gbalabasquer commented 5 years ago

Closing this issue. We have separate events since a long time ago.