daifoundation / maker-otc

The OasisDEX protocol - Simple on-chain market for ERC20 tokens
GNU Affero General Public License v3.0
101 stars 39 forks source link

Price + dust offer vulnerability fixed #166

Closed r001 closed 6 years ago

r001 commented 6 years ago

fixed bug: price changed when offer was partially matched Matcher now leaves no dust offers, vulnerability is gone. LogBump() has been removed. offer(,,,rounding) function is now deprecated, the rounding will be on no matter what the user chooses. Reorganized simple market to separate public and non-public methods. Used mul() instead of '+' in matching market to avoid possible exploits.