Kk/remove unused methods

daifoundation / maker-otc

The OasisDEX protocol - Simple on-chain market for ERC20 tokens

GNU Affero General Public License v3.0

100 stars 39 forks source link

Closed krzkaczor closed 4 years ago

krzkaczor commented 4 years ago

krzkaczor commented 4 years ago

@maciejka to remove unordered list entirely we would need to kill off bigger part of the SC:

matchingEnabled switch
methods: _offeru, _sort, _unsort, getFirstUnsortedOffer, getNextUnsortedOffer, setMatchingEnabled
events: LogMatchingEnabled
tweak logic in: offer, buy, cancel,

Do we want to do broad changes?

krzkaczor commented 4 years ago

I removed more code but I am not so sure about these changes.... @maciejka