daijiang / phyr

Functions for phylogenetic analyses
https://daijiang.github.io/phyr/
GNU General Public License v3.0
30 stars 10 forks source link

fixef #29

Closed arives closed 6 years ago

arives commented 6 years ago

Daijiang,

Could you please change the function fixef so that it doesn't conflict with fixef in lme4? Is there an easy way to do this, allowing fixef to identify the class of object?

Thanks, Tony

daijiang commented 6 years ago

Changed it to fixed_effects().

arives commented 6 years ago

Daijiang,

Couldn't you do this like "fixef.communityPGLMM" so that it wouldn't interfere with fixef in lme4?

Tony


Anthony R. Ives UW-Madison 459 Birge Hall 608-262-1519

From: Daijiang Li notifications@github.com Reply-To: daijiang/phyr reply@reply.github.com Date: Tuesday, October 9, 2018 at 4:45 PM To: daijiang/phyr phyr@noreply.github.com Cc: "Anthony R. Ives" arives@wisc.edu, Author author@noreply.github.com Subject: Re: [daijiang/phyr] fixef (#29)

Changed it to fixed_effects().

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/daijiang/phyr/issues/29#issuecomment-428363912, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALF_LMffmugHjXv-mPuSGYLJVHr61RNZks5ujRj6gaJpZM4XT9fi.

daijiang commented 6 years ago

Tony, I tried to, but importing fixef from nlme package failed. There are some annoying issues such as some functions are not exported from nlme namespace. I did not know how to deal with it yet (the issue maintained even I imported the whole nlme package). So instead, I just changed the function name to fixed_effects (fixed.effects is an alias in nlme (and thus lme4)). Is this okay? Daijiang

daijiang commented 6 years ago

Fixed. We can use fixef for communityPGLMM.

arives commented 6 years ago

Great. So you managed to fix fixef in nlme?

daijiang commented 6 years ago

Sort of. I ended with still import fixef from lme4, which was in turn imported from nlme. But I think it works now. ba59852457570e3ab124eba9351ec7a7ac1df458

arives commented 6 years ago

Ugh. Complicated.