daijiang / phyr

Functions for phylogenetic analyses
https://daijiang.github.io/phyr/
GNU General Public License v3.0
30 stars 10 forks source link

Fix cp valgrind #44

Closed lucasnell closed 4 years ago

lucasnell commented 4 years ago

This still has valgrind errors on my local Docker container.

However, with track-origins=yes, the source of the uninitialized value is a stack allocation in the function dlatrs_ (in /usr/lib/libopenblasp-r0.2.19.so), not inside phyr code. I was also very careful to avoid non-initialized items in any matrices/vectors. Given that this error is occurring in the likelihood function, the output from cor_phylo would very likely be influenced by it; no problems like this show up in the tests. Thus, I believe the source of this error is in the /usr/lib/libopenblasp-r0.2.19.so library.

Hopefully this explanation is sufficient for the CRAN maintainers.