daikikatsuragawa / clasp-action

This action uses clasp to push or deploy to Google Apps Script.
https://github.com/marketplace/actions/clasp-action
MIT License
32 stars 14 forks source link

Deployment errors should show a failed deployment in Github Actions #7

Open alex-galey opened 2 years ago

alex-galey commented 2 years ago

I had difficulties spotting a bug in a script today because Github action deployments were green for success but deployments had failed indeed. So I thought the bug was in the script logic ...

Deployment error due to Gaxios errors should throw an error

@daikikatsuragawa, @joseffffff, do you have an idea how I could implement this behaviour ?

daikikatsuragawa commented 2 years ago

I am very sorry for the delay in replying. Thank you for reporting the bug. I will consider it as well. However, I would be very grateful if someone could create a PR.

alex-galey commented 2 years ago

This should be solved by https://github.com/google/clasp/pull/857 But it has still not been merged for an unknown reason ...