Find/Replace dialog UI arrangement issues for Mac Version

ErickWei commented 7 months ago

Wish that the dialog box could be updated to be as perfectly arranged as the one in Windows

The main problem is that the widths of the textboxes/combobox are not consistent and they are not left-aligned

MAC OS:

Windows:

dail8859 commented 7 months ago

I don't have a Mac to develop/test on so hopefully somebody can submit a PR. My guess is something with the layouts just need tweaked.

ErickWei commented 7 months ago

Debug via QT on macos,but get an error,Do you have any suggestions on how to solve this issue?

dail8859 commented 7 months ago

I'm assuming you also checked out the submodules?

git clone --recurse-submodules https://github.com/dail8859/NotepadNext.git

I know it is possible to build with mac but beyond that I'm not sure.

ErickWei commented 7 months ago

Just update 4 property of formLayout.

layoutLableAlignment-Horizontal:AlignLeft
layoutFormAlignment-Horizontal:AlignJustify
layoutSizeConstraint:SetNoConstraint
layoutFieldGrowthPolicy:First change to ExpandingFieldGrow then change back to AllNonFixedFieldsGrow, and AllNonFixedFieldsGrow is the final value. The layoutFieldGrowthPolicy must to be modified, or it won't be effective.I guess it is because, without modification, the program will set different default values for different platforms, which causes UI arrangement problems under the Mac platform.

I have tested both on Windows and Mac, and there is no problem.

Modified appearance:

But there is one thing to note, when I clone the repository to mac and windows, and open the project with qt, the values of the two property below are different:

MAC:

layoutLableAlignment-Horizontal:AlignRight
layoutFormAlignment-Horizontal:AlignHCenter

WINDOWS:

layoutLableAlignment-Horizontal:AlignLeft
layoutFormAlignment-Horizontal:AlignLeft

So, if you are modifying in the windows, you must change layoutLableAlignment-Horizontal to other value first, then change it back to AlignLeft

dail8859 commented 7 months ago

Can you create a PR for whatever works on Mac and I can review it on Windows and make sure it still looks ok?

ErickWei commented 7 months ago

Can you create a PR for whatever works on Mac and I can review it on Windows and make sure it still looks ok?

Okay,wait for me

dail8859 commented 7 months ago

Closed by #538

dail8859 / NotepadNext

Find/Replace dialog UI arrangement issues for Mac Version #535