rename cmd name NotepadNext to notepad-next

zoujiaqing commented 3 months ago

Description

rename cmd name NotepadNext to notepad-next or notepadnext.

On unix systems the command specification is all lowercase. Includes macOS/FreeBSD/Linux and other systems.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

dail8859 commented 3 months ago

How did you install the application? Flathub? AppImage? etc?

zoujiaqing commented 3 months ago

brew install

dail8859 commented 3 months ago

@woj-tek Thoughts on this?

woj-tek commented 3 months ago

+1

@zoujiaqing is correct that *nix shell is case-sensitive thus renaming it to notepad-next would be convenient.

I haven't noticed it because I configured my shell with set completion-ignore-case on as it's more covenient that way :)

dail8859 commented 3 months ago

Is there a preference of notepad-next vs notepadnext?

The only reason I ask is on Windows you can run start notepadnext and figured if there's no real reason to keep the - then we can keep things consistent. But if for Mac/unix/etc users if notepad-next is more natural that's fine too.

woj-tek commented 3 months ago

I think there is not preference on system-level. For me notepad-next feels more readable but this is just very IMHO opinion :)

Autocomplete should work fine with both.

dail8859 commented 3 months ago

Well I'm honestly fine with whatever then. Not sure if something needs changed in the info.plist in this repo or something in the cask file.

Willing to accept a PR to fix it.

woj-tek commented 3 months ago

Well I'm honestly fine with whatever then. Not sure if something needs changed in the info.plist in this repo or something in the cask file.

Hmm... From what I can see it just used binary from the package (after installation):

$ file /opt/homebrew/Caskroom/notepadnext/0.8/Notepadnext.app/Contents/MacOS/NotepadNext
/opt/homebrew/Caskroom/notepadnext/0.8/Notepadnext.app/Contents/MacOS/NotepadNext: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64]
/opt/homebrew/Caskroom/notepadnext/0.8/Notepadnext.app/Contents/MacOS/NotepadNext (for architecture x86_64):    Mach-O 64-bit executable x86_64
/opt/homebrew/Caskroom/notepadnext/0.8/Notepadnext.app/Contents/MacOS/NotepadNext (for architecture arm64): Mach-O 64-bit executable arm64

Looking at the homebrew documentation (https://docs.brew.sh/Cask-Cookbook#stanza-binary) switching from:

binary "#{appdir}/Notepadnext.app/Contents/MacOS/NotepadNext"

to

binary "#{appdir}/Notepadnext.app/Contents/MacOS/NotepadNext", target: "notepad-next"

PR: https://github.com/dail8859/homebrew-notepadnext/pull/1

dail8859 commented 3 months ago

@woj-tek Thanks for looking into this!

Closed by https://github.com/dail8859/homebrew-notepadnext/pull/1

dail8859 / NotepadNext