search

dail8859 / SurroundSelection

Notepad++ plugin to automatically surround the selection in quotes/brackets/parenthesis
GNU General Public License v2.0
55 stars 5 forks source link

Version 1.3 zip issue for PluginAdmin #11

Closed chcg closed 5 years ago

chcg commented 5 years ago

The dll contains an extra dir SurroundSelection in the zip file, see https://github.com/dail8859/SurroundSelection/releases/download/v1.3/SurroundSelection_v1.3.zip.

Was this done intentionally? This way it can't be used by PluginAdmin. Probably this was done for the early stages of PA in 7.6.x.

dail8859 commented 5 years ago

Was this done intentionally?

I'm....honestly not sure. My goal is to be compatible with the PluginAdmin. I haven't had much free time lately to dedicate to all my various plugins :)

chcg commented 5 years ago

@dail8859 For the PA since (as fas as I remember 7.6.2 or 7.6.3) the main plugin dll needs to be in the top level directory of the zip again to be compatible with the needs of PA. So the format of v1.2 is ok, but current v1.3 zip with the extra SurroundSelection dir not. Could you please correct that.

dail8859 commented 5 years ago

Yeah you are right. I updated the appveyor file and for some reason got in my head it needed to be in a subdirectory. :)

dail8859 commented 5 years ago

@chcg Thanks for catching this. New release: https://github.com/dail8859/SurroundSelection/releases/tag/v1.3.1