search

daily-co / daily-js

https://docs.daily.co/reference/daily-js
BSD 2-Clause "Simplified" License
103 stars 33 forks source link

BUG: Fullscreen button doesn't work in prebuilt UI #209

Closed fantoine closed 1 year ago

fantoine commented 1 year ago

Expected behavior

I expect the "fullscreen" button in the prebuilt UI to open the room in fullscreen.

Describe the bug (unexpected behavior)

Since version 0.38.0 of @daily-co/daily-js, the fullscreen button doesn't do anything.

It does not open the room in fullscreen nor trigger any error.

I suspect this commit introduced this problem.

Steps to reproduce

  1. Go to any Daily room in a prebuilt UI
  2. Click on the "fullscreen" anything
  3. Nothing happens

Screenshots

N/A

System information

* Device: MacBook * OS, version: MacOS * Browser, version: Brave, Chrome, Firefox, Safari... # Additional context

N/A

mattieruth commented 1 year ago

Hi! Thank you for the report. This should be resolved in the latest release, 0.40.0.