daily-co / daily-js

https://docs.daily.co/reference/daily-js
BSD 2-Clause "Simplified" License
102 stars 33 forks source link

BUG: Tooltip used as label for customButton on small screen #259

Open acarlsen opened 14 hours ago

acarlsen commented 14 hours ago

Expected behavior

We use customTrayButtions, example:

 customTrayButtons: {
      customButtonOne: {
        iconPath: 'path/to/icon',
        label: 'Share file',
        tooltip: 'Click here to upload files to the meeting',
      }
    },

Icon is displayed fine on normal size screen with correct label. We also expect label to be used on small screen when custom button is displayed in overflow menu popup.

Describe the bug (unexpected behavior)

When custom button is shown in overflow menu on small screen, the tooltip text is used as label for icon, making the text to long to fit in the window (text is limited to one line).

Steps to reproduce

  1. Create custom button as example above
  2. Join video metting, use chrome dev tools to force button to be displayed in "***" overflow menu popup.
  3. See that the tooltip text is used as label for custom button.

Screenshots

Normal screen (using correct label): Screenshot 2024-11-18 at 15 15 40

Small screen using tooltip as label: Screenshot 2024-11-18 at 15 16 05

System information

mattieruth commented 7 hours ago

Thanks for the report! We will look into this and get back to you.