search

daily-co / react-native-daily-js

https://docs.daily.co/reference/rn-daily-js
BSD 2-Clause "Simplified" License
35 stars 12 forks source link

Warning with newer React Native in the web-rtc dependency #21

Open op opened 2 years ago

op commented 2 years ago

Hi! Friendly warning that the react-native-webrtc creates a warning with newer versions of React Native. :butterfly:

More details to be found here: https://github.com/react-native-webrtc/react-native-webrtc/issues/1070 https://github.com/react-native-webrtc/react-native-webrtc/commit/a5c881916a13a21bcc926669eeab4bf85909e358

Given that the fix for this doesn't do much, I assume it's safe to ignore it. For anyone else also wanting to silence it, I used this workaround;

LogBox.ignoreLogs([
  /NativeEventEmitter/, // react-native-webrtc
]);
filipi87 commented 2 years ago

Hi @op thanks for the warning, we are already working bringing all the changes of the react-native-webrtc to our fork. https://github.com/daily-co/react-native-webrtc/pull/17

filipi87 commented 2 years ago

Even after updating the react-native-webrtc version, this warning still continues.

In our case, the problem is with the react-native-background-timer, which as we can see, already has an opened issue for that: https://github.com/ocetnik/react-native-background-timer/issues/366

Until this bug is not fixed by react-native-background-timer, ignoring this warning in your app, as suggested by @op above, can be an alternative.