🐛 BUG: 'Welcome to squad' message isn't populated from mobile notification

frank-connolly commented 4 months ago

What went wrong? 🤔

As a squad admin, when I get a 'someone joined your squad welcome them' notification. On desktop clicking it brings me to comment on welcome post autopopulated with their tag and welcome. On mobile it's blank.

Expected Behavior

Mobile behaviour should match desktop.

Steps to Reproduce Issue

1. Go to 'X joined your squad' notification
2. Click on the notification on desktop and repeat on mobile
3. See the difference in the comment placeholder

Solution Proposed

Review desktop event on notification link. Mirror it on mobile.

Screenshots

![DESCRIPTION](LINK.png)

Environment

No response

Browsers

Chrome

OS

Windows

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

[X] I follow the conditions of this project.

idoshamun commented 4 months ago

Hi @frank-connolly,

Thanks for the report! We'll look into it.

Sidenote: do you find this call to action useful as a squad admin?

frank-connolly commented 4 months ago

Hi @frank-connolly,

Thanks for the report! We'll look into it.

Sidenote: do you find this call to action useful as a squad admin?

Yes people seem to appreciate a welcome note and I'm not always at my desktop.

sshanzel commented 4 months ago

Thank you for reporting! 🥳

The issue is most likely within the CommentModal which is used on mobile only. The initialContent from the props is probably not being utilized at the moment. Incorporating it within the component itself should most likely fix the issue. For anyone interested 👀

dailydotdev / daily