dailydotdev / daily

daily.dev is a professional network for developers to learn, collaborate, and grow together 👩🏽‍💻 👨‍💻
https://daily.dev
GNU Affero General Public License v3.0
18.06k stars 467 forks source link

🐛 BUG: Companion app is displayed on top off youtube videos in fullscreen #1354

Open dustessavdh opened 1 month ago

dustessavdh commented 1 month ago

What went wrong? 🤔

I opened a YouTube video from daily.dev and started watching it. When going into full-screen mode, the companion app remains visible and is displayed on top of the video.

msedge_jdbxiKHD8Q

Expected Behavior

I would expect the companion app to be hidden when watching something in full-screen.

Steps to Reproduce Issue

1. Go to https://app.daily.dev/posts/uuPr6wUya
2. Click on Watch 'Video'
3. Click on 'Full-screen'
4. See the companion app is still visible.

Solution Proposed

I would propose that the companion app hides itself in full-screen mode. This might be relevant for this: https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API/Guide

Screenshots

See `What went wrong?`

Environment

Windows 11, Edge Version 127.0.2651.105

Browsers

Microsoft Edge

OS

Windows

Version of daily.dev

3.33.8

Additional Context

No response

Code of Conduct

rebelchris commented 1 month ago

@dustessavdh Good point, we tried to set it to a max top, but this is a good edge-case to consider.