Implement a destroy method for the sdk and the inline integration - Githubissues

dailymotion / dailymotion-sdk-js

Dailymotion JavaScript client API

https://developers.dailymotion.com/api/platform-api/

MIT License

34 stars 33 forks source link

Implement a destroy method for the sdk and the inline integration #72

Closed Supergallus closed 5 years ago

Supergallus commented 5 years ago

Just launch tests/player.html in your browser & play with Create / Destroy / Command buttons to drive the Player

When you Create the Player, <iframe> will appear in place of the <div id="player">
When you Destroy, <div id="player"> will be back and <iframe> will be deleted (& everything related to it)

Steps

[x] remove the iframe (+ any other inserted HTML elements from DOM) iframe is replaced by its initial anchor
[x] remove every reference to the player iframe
[x] remove all event handlers (from the SDK stand-point)
[x] enrich test page
[x] Make sure that we can still use the SDK to create/play with another Player

cool

Supergallus commented 5 years ago

if no param id is passed to destroy() function, all the player of the page are destroyed