search

dailymotion / vast-client-js

VAST (up to 6) parsing library for JavaScript
https://iabtechlab.com/wp-content/uploads/2022/09/VAST_4.3.pdf
MIT License
367 stars 215 forks source link

SetProgress is avoiding quartileEvents to be fired several times #460

Closed rs-guian closed 4 months ago

rs-guian commented 1 year ago

vast-client-js 5.0.0

Using the VPAIDTracker to call event urls. We have the setProgress call on video progress, this fires quartile automatically wich is convenient. issue is :

Some of or publishers are using a replay button so the ad can be rewound. setProgress is calling the "rewind" event as expected but then the quatile events are not fired anymore.

This is because the setProgress event is setting "once: true" on track() call which removes the tracking urls from the url array. To avoid this we trigger quartile urls directly with track() and avoid using setProgress.

can we add a parameter on setProgress ( 'trackOnce' = true ) so anyone can set it to false if needed please ?

made the pull request here : https://github.com/dailymotion/vast-client-js/pull/461

Rapha0511 commented 1 year ago

Hello ! Thanks for raising this issue :)

This is an interesting feature to add since it does not modify the initial behavior of the setProgress() function and it allows more adaptability for specific needs.

I will look further into your pull request. :)

rs-guian commented 12 months ago

Seen the pull request be merged. When will it be available ? Is next release planned yet ?

Rapha0511 commented 11 months ago

It will be available in the coming weeks :)

rs-guian commented 10 months ago

Hello dailymotion team.

I came here to get updates. Is there a planned 5.1 release that includes the fix I submitted?

Rapha0511 commented 10 months ago

Hello!

A major update will be release in february. You can see the changes on this pull request .

The change you submitted has been merged to master and will be available in the next release of the vast-client. :)

ZacharieTFR commented 4 months ago

Hello, closing this issue as it has been fixed in 6.0.0 version