search

dailymotion / vast-client-js

VAST (up to 6) parsing library for JavaScript
https://iabtechlab.com/wp-content/uploads/2022/09/VAST_4.3.pdf
MIT License
367 stars 216 forks source link

Add raw XML string to url handler callback #464

Closed epechuzal closed 10 months ago

epechuzal commented 10 months ago

Description

Include the raw XML string in the details object returned by node URL handler.

We would like to use this for debugging purposes.

Type

Rapha0511 commented 10 months ago

Hello, Thank you for your contribution!

this is definitely something that can be added in the object returned by the url handler.

However, the url handler itself will be updated in this upcoming pull request.

I will incorporate your suggested change into this pull request, and you can expect it to be available in the next release.

If you have any further questions or if there's anything else you'd like to discuss regarding this change, please don't hesitate to reach out.

epechuzal commented 10 months ago

@Rapha0511 Thank you!

I noticed the url handler param and that's what I do locally (my url handler is basically a copy/paste of this one + the raw xml change). It sounds like when the update comes I can just ditch the url handler and go back to using the provided one :)

Should I close this PR? Sounds like it is redundant given the upcoming changes.

Rapha0511 commented 10 months ago

Hello !

Your suggested change has been pushed on the PR and you will be able to use the url handler provided by the vast-client on the next release :) I'm closing this PR since it will be a duplicate change.

Thank you for your contribution :)