search

dailypenn / eventsatpenn

Penn campus events aggregation website with Facebook integration
0 stars 0 forks source link

All events say "cont" in day view, rather than the time they actually start #102

Open alexwgraves opened 6 years ago

alexwgraves commented 6 years ago

This breaks on November 5, which was daylight savings time. Fixing #89 (which should be fixed with #63 lol) should fix this.

dpwebadmin commented 6 years ago

I'm voting we label this as a WONTFIX for now as this really should be refactored to be a partial. Then, we can mark the calendar as a permanent element and have the sidebar generated serverside and injected into the page without all of the jQuery insanity we have going on now.

This would also allow us to remove the remainder of the JSON endpoints (I think), which shouldn't really be open to the public until we decide to open up a public API.

On Wed, Jan 3, 2018 at 12:22 PM, Alex Graves notifications@github.com wrote:

Something's messed up with the logic on this, I guess

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dailypenn/eventsatpenn/issues/102, or mute the thread https://github.com/notifications/unsubscribe-auth/AFug5XAoL_S5opq54bnUlCb9us9roKNXks5tG7dRgaJpZM4RSBEC .

--

[image: The Daily Pennsylvanian] http://www.thedp.com/ Andrew Fischer Director of Online Projects E fischer@thedp.com | T (917) 526-3831 <9175263831>