search

daimajia / AndroidImageSlider

An amazing and convenient Android image slider.
MIT License
5.63k stars 1.66k forks source link

when some pic load fail didn't callback PageIndicator to remove corresponding dot #62

Open lightSky opened 9 years ago

lightSky commented 9 years ago

First, thanks a lot for your lib ,I learn a lot from it :) When I use the lib load pic from Internet,some pic loaded fail,the page is invalid page is remove by removeSlider method of SlideAdapter but didn't callback PageIndicator to remove corresponding dot,cause invalid dot exists.

lightSky commented 9 years ago

Sorry,I findthe dataChangeObserver in PagerIndicator yet ,and it indeed performs the removeView(mIndicators.get(0)) method ,but didn't work. I replace it of redraw() and delete the code :mPager.setCurrentItem(mItemCount*20 + mPager.getCurrentItem()); it works.
(setCurrentItem cause a fast jump between dots)

daimajia commented 9 years ago

The fast jump problem has been fixed in version 1.1.2, please make sure that you are using the latest library.