daimajia / AndroidSwipeLayout

The Most Powerful Swipe Layout!
MIT License
12.38k stars 2.67k forks source link

Enabled Swiping with multiple DragEdges #40

Closed ofermoshsaioff closed 9 years ago

ofermoshsaioff commented 10 years ago

You should really consider adding the ability to swipe to multiple directions. I.E. - left and right, or left and top for example.

iAviatorJose commented 9 years ago

@HarshEvilGeek i checked your new changes in your forked repo its working superb.

iAviatorJose commented 9 years ago

@daimajia please integrate the new changes!!!

daimajia commented 9 years ago

@iAviatorJose Just like HarshEvilGeek said:

Great, if the changes are done, I need to get clearance for the pull request (only because I worked on this for my job). Will ask for it now, and I'll commit in a few days I hope. They just need to confirm I'm not sharing any proprietary code or anything.

Waiting for his PR.

HarshEvilGeek commented 9 years ago

Hey, just got approval for the PR, and to continue to work on this repository on my own time if I wish. @daimajia , do you want me to keep the top swipe on the first layout? Or should I remove it and then initiate the request. Or should I just go ahead?

iAviatorJose commented 9 years ago

@daimajia @HarshEvilGeek i suggest you guys to keep the Top Swipe. May be Somebody needs such a ui feature in their projects.

daimajia commented 9 years ago

Sorry for my delay reply. Recently it's Chinese new year. Happy new year to all of you. ^.^

@HarshEvilGeek Agree with @iAviatorJose Keep it~

HarshEvilGeek commented 9 years ago

Happy New Year, @daimajia . I assumed that's why you were busy :). Just raised the pull request. I definitely intended to keep the top swipe functionality. I just thought you might wanted me to take it off the first layout specifically for now, since it doesn't look that great (the star is quite small). Anyway, we can definitely modify that later.

I apologize for the delay, I'll be able to make changes much faster now (though I might have less time)

iAviatorJose commented 9 years ago

@daimajia Happy New Year!!!

daimajia commented 9 years ago

@HarshEvilGeek Merged ! ! ! I'll prettify the sample project right now. This issue can be closed. Thanks again!

Jabelriera commented 9 years ago

Hi @daimajia, @HarshEvilGeek,

I have checked all the comments above and had a quick look at the library, but I am not sure if I have understood everything. I need to be able to do swipe right to left and left to right in a same ListView item with different actions (and layouts in the background). Is it possible ?

I have seen the different swipe types but I am not sure if two swipe directions can be set at the same time with different results set.

Thank you very much for everything, the lib looks amazing!

dileepan commented 9 years ago

@Jabelriera This is a code excerpt from the demo app in the MyActivity.java file. Hope those lines answers your question

sample1.setDragEdges(SwipeLayout.DragEdge.Left, SwipeLayout.DragEdge.Right, SwipeLayout.DragEdge.Top); // When using multiple drag edges it's a good idea to pass the ids of the views that you're using for the left, right, top bottom views (-1 if you're not using a particular view) sample1.setBottomViewIds(R.id.bottom_wrapper, R.id.bottom_wrapper_2, R.id.starbott, SwipeLayout.EMPTY_LAYOUT);

Jabelriera commented 9 years ago

Thank you very much @dileepan !

EDIT: I have had looked again for what I asked and what it seems it was refering ( @dileepan ) is when you have more than one view with swype layout in the screen, not more than one dragging edge in one item (ListView Item in my case). So it seems that this library does not support to set multiple edge dragging in the same item for now if I am not wrong...

rizwanbpatel commented 7 years ago

Thank you guys @daimajia, @HarshEvilGeek, For a fantastic library for Swipe support. This helps alot in multiple edge swipe.