search

daimajia / AndroidSwipeLayout

The Most Powerful Swipe Layout!
MIT License
12.38k stars 2.67k forks source link

fully open & closed mode cause to lags #51

Closed yoavst closed 9 years ago

yoavst commented 9 years ago

When I opened it to the max or hide it, it has a lag, so I can't immediately swipe.

daimajia commented 9 years ago

Can you show me a screenshot or video (gif)?

or send me an apk ?

yoavst commented 9 years ago

happens for me also in the sample project. I'll send once I back from school. Also, it crash me sometimes when I slide 2 items together, can't fully replicate it.

My app is: https://play.google.com/store/apps/details?id=com.yoavst.hebjokefinal it is inside recyclerview

daimajia commented 9 years ago

Well, I installed the app you mentioned, but I don't know where you used the SwipeLayout ...

yoavst commented 9 years ago

I can't really explain it. try to swipe in your sample app few times, from open to close (without releasing) and you'll see it.

jpshelley commented 9 years ago

This is a really poor bug report. I'm running HTC M7 with android 4.4.2 and haven't had this issue with the sample at all. I'm also in the process to adding recycler view support so maybe wait and check back on that.

mattiasbe commented 9 years ago

@yoavst are you perhaps referring to the fact that you can't open/close it again unless you release the touch (if fully open/closed or close enough to or fully close/open that it closes/opens the rest of the way by itself)?

mattiasbe commented 9 years ago

Or maybe if you get too close to fully open/closed and it starts to move the last bit by itself, it feels a bit laggy as you work against that movement? IMHO that's a very minor point but it indeed should probably stop responding to dragging after initiating the automatic last movement.

mattiasbe commented 9 years ago

@jpshelley By the way, off topic, sorry but you mentioned RecyclerView support here, that seems to work fine already, I'm using it with v1.1.8 and it works great. Though the sample demo for it lacks some code.

jpshelley commented 9 years ago

@mattiasbe We just got merged in the RecyclerView support probably last week. If you feel there is an issue with it feel free to send a pull request.

yoavst commented 9 years ago

maybe it because of recyclerview support. I'll update the version and check it.

mattiasbe commented 9 years ago

@jpshelley (continued off topic, regarding recyclerview) nevermind, the demo was updated as well or I looked at an older tag, I vaguely recall it was missing calling the (parent's) mItemManager.bindView(..) and not even using the new RecyclerViewAdapter. Great work.

yoavst commented 9 years ago

Sorry, it is still here. In the sample, try to swipe the layout in the main screen and then without leave the hand swipe it back (after it was fully open).

daimajia commented 9 years ago

@yoavst , this issue should be fixed in the latest version, when you available, check it.