Pre-audit checklist - Githubissues

daimo-eth / p256-verifier

P256 signature verification solidity contract

https://p256.eth.limo

MIT License

172 stars 35 forks source link

Pre-audit checklist #1

Closed dcposch closed 12 months ago

dcposch commented 1 year ago

[x] Remove all commented-out code from P256Verifier.
[x] Clean up code, add thorough inline documentation.
[x] Remove reverts. EIP-7212 spec always returns 1 or 0, never reverts.
[x] Combine test vectors in a clean JSON file. Use in forge test.
- Wycheproof vectors
- Sage vectors
- others?
- [x] Measure branch coverage
- [x] Measure gas cost
- [x] Deploy on Base Goerli
- [x] Test in Daimo via 4337 contract account

dcposch commented 1 year ago

[ ] Potentially formal verification. Will talk to Veridise

nalinbhardwaj commented 12 months ago

Audit is complete #23