search

daimo-eth / p256-verifier

P256 signature verification solidity contract
https://p256.eth.limo
MIT License
147 stars 28 forks source link

Deploy P256 verifier in setup of P256 and WebAuthn tests #34

Closed doublespending closed 7 months ago

doublespending commented 7 months ago

Motivation

The uint tests in P256.t.sol and WebAuthn.sol will be fail because of miss deploying P256Verifier contract.

截屏2023-12-07 11 33 47

Solution

Deploy P256Verifier in the setup of P256 and WebAuthn tests.

nalinbhardwaj commented 7 months ago

Amazing, this can close https://github.com/daimo-eth/p256-verifier/issues/22. Would you also mind changing the CI commands to drop --fork-url "https://base-goerli.publicnode.com" here (we added it originally to handle this deployment): https://github.com/daimo-eth/p256-verifier/blob/master/.github/workflows/ci.yml#L30-L31. Then, you can also regenerate the .lcov file (as in the CI).

Thanks for the contribution

doublespending commented 7 months ago

Amazing, this can close #22. Would you also mind changing the CI commands to drop --fork-url "https://base-goerli.publicnode.com" here (we added it originally to handle this deployment): https://github.com/daimo-eth/p256-verifier/blob/master/.github/workflows/ci.yml#L30-L31. Then, you can also regenerate the .lcov file (as in the CI).

Thanks for the contribution

Sure! Check it at 804cfdd and a3577ef.