search

daimo-eth / p256-verifier

P256 signature verification solidity contract
https://p256.eth.limo
MIT License
147 stars 28 forks source link

Number all steps in WebAuthN verification #35

Closed wilsoncusack closed 5 months ago

wilsoncusack commented 6 months ago

Currently, only the steps checkAuthFlags are numbered corresponding to https://www.w3.org/TR/webauthn-2/#sctn-verifying-assertion. I thought it would be helpful to number all, put in order, and mark explicitly which are skipped.

I also added in some optimizations for comparing strings.

wilsoncusack commented 6 months ago

@nalinbhardwaj Apologies for making this now a noisy PR, I decided to also added in some optimizations so that you could review all in one spot and not have to deal with merge conflicts. No worries if you want to pick and choose pieces that you want from this.