search

dainst / idai-field

iDAI.field | Archaeological Field Recording App by the German Archaeological Institute
Apache License 2.0
36 stars 16 forks source link

Update desktop.yml #259

Closed pushkar-hue closed 1 month ago

pushkar-hue commented 2 months ago

Changed deprecated action to their update versions.

  1. actions/checkout@v3 -> actions/checkout@v4
  2. actions/node-setup@v3 -> actions/node-setup@v4
  3. node-version: 16 -> node-version: '16.x'
  4. c-hive/gha-npm-cache@v1 -> actions/cache@v3
lsteinmann commented 2 months ago

Hey @pushkar-hue , thanks for you contribution! This will close #257 . It doesn't run because GitHub switched to docker compose instead of docker-compose, so nothing to do with your change.

Just curious - why node '16.x' instead of just 16?

Also, https://github.com/c-hive/gha-npm-cache states that the functionality is part of actions/setup-node anyway - maybe something to checkout?

I'll leave this open for @tkleinke though, as he is the lead on Field Desktop.

pushkar-hue commented 2 months ago

Thank you for letting me contribute this was my first contribution.So, I apologies for any mistake on my part as I'm still learning. As of why '16.x' it just something i came across while reading about the workflow. This means if Node 16.20.1 is available the workflow will use that version instead of specifically 16.0.0 as it will provide more flexibility to bug check i added it.

tkleinke commented 1 month ago

The cache action does not work, but I don't think we need it anyway. Otherwise it looks good. I'll merge the pull request and remove the cache action.