search

daipenger / minema

A Minecraft mod for offline rendering and video capturing.
The Unlicense
108 stars 15 forks source link

Force chunk preloading on enable #1

Closed mchorse closed 7 years ago

mchorse commented 7 years ago

This pull request will allow users to configure Preload chunks feature to allow loading every chunk in the render distance on recording start. I called it Force preload chunks, but if you want to, you can rename both of those config options to be more semantic and clear.

P.S.: how do you test these SRG named reflection in Eclipse? I had to look up the names in order to make it work in Eclipse first, and then change it back to SRG.

daipenger commented 7 years ago

You can adjust your reflection code to look for both the unobfuscated and the obfuscated mapping, so that it also becomes compatible with unit testing in your dev environment.

But I, personally, test it by hand: Compile and load it up on my actual minecraft installation. It takes some time this way, but you keep your code clean and avoid the sometimes ridiculous amount of mocking. Let me tell you something: I have never unit tested any of my forge mods. If you are used to programming with the Bukkit API you can basically forget unit testing, it should be better with Forge, but I didn't try...

mchorse commented 7 years ago

@daipenger oh, I see, thanks for sharing your experience! :)

I haven't unit tested my mods either. Minecraft code is way too coupled with networking, rendering and Forge hooks, it's impossible to have clean unit tests. Anyways, unit tests are great for testing logic of your code (parsing, data processing, aggregation, etc.), it's not convenient for visuals, audio and such.