search

dairui01 / MS-TCT

[CVPR2022] MS-TCT
54 stars 11 forks source link

some bugs in charades_dataloader.py, when computing the center of G* Ground truth Heat-map #1

Closed WemChao closed 2 years ago

WemChao commented 2 years ago

on line 51

if fr / fps + 1 > mid_point and fr / fps < mid_point:

When extracting features, one segment is used every 8 frames. Usually, the frame rate of the original video is 25 frames, so it is equivalent to 3 segments per second, so at this time fps=3, there are usually three segments that meet the conditions. Therefore, in the subsequent operation counting num_action, there will be a problem of multiple records, and the heat-map will also be inaccurate.

dairui01 commented 2 years ago

Thanks for your intertest in this work. It seems that it is a small error in the code. As you pointed it out, it should be if (fr+1) / fps > mid_point and fr / fps < mid_point to limit the mid_point to a single segment. I will verify that and update the code soon.