search

daisy / ace-gui

Ace by DAISY App, the official graphical user interface for the EPUB accessibility checker developed by the DAISY Consortium, available for the Windows, MacOS and Linux desktop operating systems.
MIT License
16 stars 6 forks source link

Publications with .epub3 extension should be supported too (works with Ace CLI) #80

Closed danielweck closed 5 years ago

danielweck commented 5 years ago

Test EPUBs: https://standardebooks.org/ebooks/anton-chekhov/short-fiction/constance-garnett/ https://standardebooks.org/ebooks/miguel-de-cervantes-saavedra/don-quixote/john-ormsby

CC @acabal

danielweck commented 5 years ago

Culprit code:

https://github.com/daisy/ace-gui/blob/e4688b7b06b2ba857b524171899689e3b2513e00/src/shared/actions/app.js#L28

Context:

https://github.com/daisy/ace-gui/blob/e4688b7b06b2ba857b524171899689e3b2513e00/src/shared/actions/app.js#L26-L44

https://github.com/daisy/ace-gui/blob/e4688b7b06b2ba857b524171899689e3b2513e00/src/shared/actions/app.js#L53-L66

danielweck commented 5 years ago

Fixed via: https://github.com/daisy/ace-gui/commit/7ba80ba5ae9511c9d972a6f0866d48935ef80535

acabal commented 5 years ago

Fantastic, thanks!