search

daisy / ace

Ace by DAISY, an Accessibility Checker for EPUB
MIT License
76 stars 22 forks source link

Ace should accept accessibilityFeature values with modifiers #275

Open rdeltour opened 5 years ago

rdeltour commented 5 years ago

Some accepted values for the schema:accessibilityFeature metadata property accept modifiers, for instance "displayTransformability" can be used with a CSS-property modifier like "displayTransformability/font-size" (see the WebSchemas/Accessibility wiki page).

Ace currently uses a hard-coded list of allowed values; we should add logic to allow these modifiers.

rdeltour commented 5 years ago

(spotted after a comment from @mpakarlsson in #242)

danielweck commented 4 years ago

In the interim, I added typical / common extensions in Ace's hard-coded lists, which are used not only for validation for also for auto-completion in the metadata editor of Ace App (GUI). See: https://github.com/daisy/ace/commit/f7bd65fd7b6f243858911c08e507fe745423161d

danielweck commented 2 years ago

The original wiki page that listed possible slash-extensions is now dead, and the maintained specification does not explicitly list them. In Ace we continue to "ship" a selection of hard-coded values (notice the code comments which link to the relevant spec): https://github.com/daisy/ace/blob/55da446947af115393832fc14f1b3563597591d1/packages/ace-core/src/core/a11y-metadata.js#L121-L174