search

daisy / ace

Ace by DAISY, an Accessibility Checker for EPUB
MIT License
76 stars 22 forks source link

fixes #273 (DAISY KnowledgeBase ARIA entry for landmark-is-unique Axe check) #279

Closed danielweck closed 4 years ago

danielweck commented 5 years ago

Fixes https://github.com/daisy/ace/issues/273

danielweck commented 5 years ago

I wonder how many other Axe checks/rules need KnowledgeBase mapping? See: https://github.com/dequelabs/axe-core/tree/master/lib/checks https://github.com/dequelabs/axe-core/tree/master/lib/rules

https://github.com/daisy/ace/blob/5d4cc866af8141180980522748c0aa82830afb7a/packages/ace-report-axe/src/index.js#L19-L75

danielweck commented 5 years ago

Note that in this PR I am reusing title: localize("kb.aria-roles") instead of unnecessarily creating a new translation ... they all say "ARIA" anyway: https://github.com/daisy/ace/blob/5d4cc866af8141180980522748c0aa82830afb7a/packages/ace-report-axe/src/l10n/locales/en.json#L5-L12

danielweck commented 5 years ago

Hello @rdeltour do you have any thoughts about the second comment in this PR?

rdeltour commented 5 years ago

I wonder how many other Axe checks/rules need KnowledgeBase mapping?

As far as I remembers, the keys in this mapping are rule names. To create this map, I think we used Axe's API to return the list of rules that were enabled in the version we use.

danielweck commented 4 years ago

PR superseded with https://github.com/daisy/ace/pull/299