search

daisy / ace

Ace by DAISY, an Accessibility Checker for EPUB
MIT License
76 stars 22 forks source link

feat(l10n): add Danish localization #302

Closed ddfreiling closed 4 years ago

ddfreiling commented 4 years ago

Note: In the English translation I assumed in packages/ace-report-axe/src/l10n/locales/da.json that it was a mistake having the key "area-alt" translated to "Image maps", is this correct?

I will have Marianne, who reviewed my Danish translation of axe-core (https://github.com/dequelabs/axe-core/pull/1876), review this as well. I will let you know when it is done.

ddfreiling commented 4 years ago

Updated after review, should be ready for merge now. Thanks @MyDK !

danielweck commented 4 years ago

Hello Daniel, thank you for this contribution! Would you be interested in translating Ace App (the desktop user interface for Ace)? If so, there are instructions in this wiki page: https://github.com/daisy/ace-gui/wiki/Localization Regards, Daniel

danielweck commented 4 years ago

Merging this PR into a staging branch feat/l10n-da in preparation for final merging into master and ace-next (checks pending) Thank you! I will let you know how it goes.

danielweck commented 4 years ago

Now merged into master, thank you very much! https://github.com/daisy/ace/pull/316

ddfreiling commented 4 years ago

No problem! I will look into translating the Ace App, when I find the time.

danielweck commented 4 years ago

Hello, I have now also merged your Danish translation into the "Ace next" branch ( https://github.com/daisy/ace/pull/314 ), which introduces 2 new labels. So, could you please take a look and let me know what strings to use, and I will fix the branch:

https://github.com/daisy/ace/pull/314/commits/72c8ded9f3c972039b13ef83795ff77d5a61e7f7#diff-5530ffd4b88ca1f4ad6ea40abbc0f976

Thank you!!

ddfreiling commented 4 years ago 
"audio-caption": "Lyd",
...
"style": "Styling",

Do you want a PR for this?

danielweck commented 4 years ago

No thank you, I am integrating changes now :)

UPDATE: https://github.com/daisy/ace/commit/33d91890857c762c713a86eaf70912b79f4dc692

danielweck commented 4 years ago

Note that I added credits in the wiki page with your contributor GitHub handle: https://github.com/daisy/ace/wiki/Localization