daisy / ace

Ace by DAISY, an Accessibility Checker for EPUB
MIT License
75 stars 22 forks source link

"Landmark-unique" triggered for nav elements when landmarks are unique #341

Closed flittle8 closed 3 years ago

flittle8 commented 3 years ago

Per discussion with @mattgarrish It looks like Ace does not recognize the DPUB-ARIA roles so is seeing all three (below) as generic navigation elements. It doesn’t matter what DPUB roles are on the nav elements, it always complains.

One nav is identified as the toc, the other as the page list and a third as a generic nav.

Error message in Ace:

landmark-unique
Via: aXe
Text/toc.xhtml#epubcfi(/4/2[toc])
<nav xmlns="http://www.w3.org/1999/xhtml" xmlns:epub="http://www.idpf.org/2007/ops" epub:type="toc" id="toc" role="doc-toc"> <!--##--> <nav xmlns="http://www.w3.org/1999/xhtml" xmlns:epub="http://www.idpf.org/2007/ops" epub:type="landmarks" role="navigation"> <!--##--> <nav xmlns="http://www.w3.org/1999/xhtml" xmlns:epub="http://www.idpf.org/2007/ops" epub:type="page-list" role="doc-pagelist">
danielweck commented 3 years ago

Hello, I have moved this issue to the "Ace" project (which Ace App / GUI relies on). Thank you for reporting this bug. I am working on a series of related improvements and bugfixes.

jenstroeger commented 3 years ago

@danielweck, is it possible to add a link to the moved issue?

danielweck commented 3 years ago

Fixed via https://github.com/daisy/axe-core/commit/1a8dd7a516927850a44d87004ce25456c58c1404 (will be shipped shortly as part of ace-next which will replace Ace 1.1.1)