search

daisy / ace

Ace by DAISY, an Accessibility Checker for EPUB
MIT License
75 stars 22 forks source link

Add which accessibilityFeature, accessibilityHazard, etc. is invalid in the HTML report #343

Closed clapierre closed 2 years ago

clapierre commented 3 years ago

Ace Command Line v1.1.1 When you report metadata-accessibilityfeature-invalid or others like metadata-accessibilityhazard-invalid etc.

Under the details section it would be helpful to also report which item you are referring to. ie: "resizeText" or could be a typo like "alterativeText"

Right now you have to go through every feature to see which one is incorrect, you obviously have this information so please add it in the description to make it easier.

Thanks

danielweck commented 3 years ago

We are aware of several places in the report where the information could be more useful (another example: missing role attribute values alongside existing epub:type attributes, currently no hint is provided to help the user figure out the mapping) This will be addressed in a future revision, the current development spring is a large refactoring of Ace + Axe, which will be released shortly. https://github.com/daisy/ace/pull/314

danielweck commented 2 years ago

The JSON report contains the information:

https://github.com/daisy/ace/blob/b5d1b66b7008e0ad94a91341e6f5ac8d793b0e85/packages/ace-core/src/l10n/locales/en.json#L15-L20

https://github.com/daisy/ace/blob/b5d1b66b7008e0ad94a91341e6f5ac8d793b0e85/packages/ace-core/src/checker/checker-epub.js#L130-L135

https://github.com/daisy/ace/blob/b5d1b66b7008e0ad94a91341e6f5ac8d793b0e85/packages/ace-core/src/checker/checker-epub.js#L27-L42

danielweck commented 2 years ago

I checked that the HTML report contains the information too. This issue can be closed.