daisy / ace

Ace by DAISY, an Accessibility Checker for EPUB
MIT License
75 stars 22 forks source link

dev(internals): Electron Axe runner, migrate away from HTTP server (Express middleware / routes) #357

Closed danielweck closed 2 years ago

danielweck commented 3 years ago

Electron 13 has good support for registerStreamProtocol() now (with secure HTTPs privileges), including audio/video streaming which was failing in earlier versions (not a major issue in typical Ace usage scenarios, but worth noting nonetheless). So let's remove Express, HTTP self-signed certificate, etc. and replace with a lightweight alternative that will not expose the HTTP port on localhost (which in itself can trigger firewall rules)

danielweck commented 2 years ago

Fixed via https://github.com/daisy/ace/commit/36adc695eca25e3ba0f1f8edd368b35c39b67008