search

daisy / pipeline-framework

Core projects for the DAISY Pipeline 2 runtime framework
9 stars 2 forks source link

Use websockets for push notifications #125

Open bertfrees opened 6 years ago

bertfrees commented 6 years ago

Not sure if this idea was ever explored?

josteinaj commented 6 years ago

I think @marisademeglio had a look at it like 5 years ago or so? There's probably better libraries for it now.

marisademeglio commented 6 years ago

@josteinaj i thought you were the one who looked at it 😂 or was that on the web UI side? like you said, it's been a few years so there's probably something better now.

josteinaj commented 6 years ago

Oh, hmm. Well I've never really touched the engine code so maybe you had a look at websocket libraries for the engine and I had a look at websocket libraries for the Web UI. In any case, I think the reason we didn't do it was a combination of there not being any really good libraries to do it, and that it wasn't really worth the effort at the time. Pulling for updates once every second is usually fine. There was also the callback mechanism that was implemented as a way to push messages to clients, but I don't remember if that's still supported in the engine.

Websocket support would be nice. If someone has time to look into it :)