Closed bertfrees closed 5 years ago
@rdeltour Travis does not seem to build this branch. Do you know why? .travis.yml
says branches: {only: [master]}
, but this is also the case for other repos where Travis does build.
A more in-depth review would be nice, yes. Of all the PR's this is the main one, the one with the most significant changes. I have added a summary.
Summary of the changes:
Generalize VALIDATION_FAIL to FAIL
see issue https://github.com/daisy/pipeline-framework/issues/121
Find "status" port based on the media-type "application/vnd.pipeline.status+xml"
See https://github.com/daisy/pipeline-framework/issues/122
Fix "unsetPropertyPublisherFactory" error
see https://github.com/daisy/xproc-maven-plugin/issues/23
Properly support StreamResults in XProcOutput
Previously each provided Result was being replaced with a newly created Result based on its systemId. Changed that so that Results are not replaced anymore if they are of type StreamResult.
Improve exception handling
Refactoring of messages API
Changes to job XML
Support sending messages to execution log from Java
The system automatically associates messages with the current job. This is done using the same MDC based principle that is already used in IgnoreSiftAppender, the class responsible for logging different jobs to different log files.
For convenience, the event bus now also implements the SLF4J Logger API.
Support posting messages to EventBus through SLF4J
without needing direct access to the EventBus. This happens via a custom Logback appender.
This feature is intended mainly for channelling log messages from external libraries to the execution log.
It also follows the proposal of unifying the two types of messages (execution log and detailed log) through one and the same mechanism, except that XProc/XSLT messages are still sent directly to the EventBus: see issue https://github.com/daisy/pipeline-issues/issues/478.
logging-activator: enable all JUL log levels
This can be done without a performance penalty because we are using LevelChangePropagator (https://logback.qos.ch/manual/configuration.html#LevelChangePropagator).
Drop CallbackRegistry indirection
Added a lot of tests
Depends on
Can be tested on https://github.com/daisy/pipeline/compare/messages.