search

daisy / pipeline-gui

Desktop GUI interface for the pipeline
GNU Lesser General Public License v2.1
1 stars 2 forks source link

Validate job form before submitting #58

Open bertfrees opened 7 years ago

bertfrees commented 7 years ago

With this I mean using the available px:data-type and px:type information of options.

The px:type="boolean" info is already used (made into checkbox).

The px:type="integer" or px:type="xs:integer" info could be used to create number fields.

Currently the "officially" supported custom data-types are enumerations and regex patterns. They are expressed in (a subset of) RelaxNG. A first step would be to just validate them (preferably this would happen in the framework through the Java API for data-types). A next step would be to create special widgets for these custom data-types (e.g. drop-down lists), like was done in the web UI.

It would maybe also be nice if the feedback from the validation could be rendered in the form itself instead of in the messages list (although I'm not sure what the impact would be on the accessibility).

Related:

P.S: px:data-type and px:type should be merged.

bertfrees commented 7 years ago

Note that integers are already validated as such, there are just no special number fields yet.

bertfrees commented 7 years ago

See PR: https://github.com/daisy/pipeline-gui/pull/65

bertfrees commented 6 years ago

@mccallum-sgd This would be nice I think.