search

daisy / pipeline-gui

Desktop GUI interface for the pipeline
GNU Lesser General Public License v2.1
1 stars 2 forks source link

Move File > Exit to bottom of Menu #76

Open mccallum-sgd opened 6 years ago

mccallum-sgd commented 6 years ago

It's more conventional to have an Exit option at the very bottom of a menu, and preferably with a divider (SeparatorMenuItem) separating it: this makes it less likely the user will select it on accident.

So I think we should move the Exit MenuItem to the very bottom of the File menu.

marisademeglio commented 6 years ago

Isn't this already the case, minus the separator? On Mac, "Quit" should be under the application menu, and on windows, "Exit" should be under the file menu.

https://github.com/daisy/pipeline/blob/master/gui/src/main/java/org/daisy/pipeline/gui/AppMenu.java#L103

mccallum-sgd commented 6 years ago

It's never been at the bottom for me (on Windows 10). screenshot 3

And in the code you linked you can see that it's not added at the bottom -- the "Run job", "Delete job", "Run job again", and "Copy messages to clipboard" MenuItems are all added after "Exit".

Maybe I wasn't specific enough in my description, I revised it a bit!

mccallum-sgd commented 6 years ago

Implemented in daisy/pipeline@792828685dc753d08d3cbc1950868dfdb6e1c6aa.

I'll rebase the branch and test it again soon.