daisy / pipeline-mod-audio

!! NOTE: This project is now part of the pipeline-modules project !! | Audio-related modules for the DAISY Pipeline 2
0 stars 0 forks source link

New API for audio encoders #11

Closed rom1mouret closed 10 years ago

rom1mouret commented 10 years ago
rdeltour commented 10 years ago

LGTM except for the two minor inline comments.

The change introduces an API break, but it's OK AFAICS. Alternatively we could keep the old signature and add a new method accepting a list of buffers if that makes sense, your call.

rom1mouret commented 10 years ago

I prefer the API break option. I changed the versions to make it compile, but I thought actual version increments had to be done when merging PRs (http://code.google.com/p/daisy-pipeline/wiki/Versioning) so that it makes sense to merge PR in any order?

rdeltour commented 10 years ago

I prefer the API break option.

OK, fine by me.

I changed the versions to make it compile, but I thought actual version increments had to be done when merging PRs

Yes, you're right. Just wanted to make sure you were aware of that.

rdeltour commented 10 years ago

Merged as 04dfabb0b144b5e2f5fe722245bfc6dccfa588e0