search

daisy / pipeline-mod-braille

!! NOTE: This project is now part of the pipeline-modules project !! | Braille Production Modules for the DAISY Pipeline 2
1 stars 3 forks source link

More useful feedback from validation in dotify:xml-to-obfl #89

Open bertfrees opened 8 years ago

bertfrees commented 8 years ago

Maybe return a proper validation report?

How does this relate to https://github.com/snaekobbi/pipeline-mod-mtm/issues/9?

CC @joeha480

joeha480 commented 8 years ago

@bertfrees If it is the dtbook checks before the OBFL conversion (xslt) we're talking about, then I think this is related to the missing java logging https://github.com/daisy/pipeline-assembly/issues/87

... Or maybe these are printed directly to standard out? I can't check right now how the schematron messages are printed, but I still haven't seen any java logging messages from the GUI so I can't rule that out either.

bertfrees commented 8 years ago

Just to be clear: What Björn is talking about is what he can see in the GUI, the messages under "Execution log". Are you talking about that too? Everything that is logged in Java is send to the detailed log file, accessible through the button "Download detailed log" and only really useful for developers or for including in a bug report or something. The job messages (events) and the log serve two slightly different purposes (but I can understand it causes confusion).

I you haven't seen any Java logging messages in the GUI, that is perfectly normal. But you should have seen them them in the detailed log because the issue has been fixed for a while now (hope that's still the case).

If really what you want is Dotify log messages to go to the "event bus" we'll have to do something special. There are several other improvements that need to be done w.r.t. messaging, I'm planning to address them all in phase 3.

joeha480 commented 8 years ago

I am not getting any detailed log what so ever at the moment, so I can't really tell, but I haven't seen any log messages from Dotify at any point in the advanced log.

See for example: jobs/2680/log

bertfrees commented 8 years ago

OK. Just wanted to make sure there were no misunderstandings. I've also noticed that the log file is not accessible at all at the moment, Jostein is looking at it.

josteinaj commented 8 years ago

yes, related: https://github.com/daisy/pipeline-webui/issues/58

bertfrees commented 8 years ago

With the newest improvements to messaging, all Dotify log messages with level INFO or higher will be send to both execution log and detailed log, and all messages with level DEBUG or higher are send to the detailed log. The level threshold is configurable in configuration files by the way, so if there is a need to include more Dotify messages that would be possible.

This is all in theory. The problem we are having with Dotify messages not ending up in the detailed log might well affect the execution log too.