daisy / pipeline-modules

Modules for the DAISY Pipeline project
4 stars 5 forks source link

[tts-adapter-sapinative] re-unify microsoft voices native adapters #105

Closed NPavie closed 1 month ago

NPavie commented 2 months ago

Given the issues encountered with breaking changes between Windows updates with the WinRT runtime, this PR aims to reunify the Onecore and SAPI native adapters in favor of using the legacy SAPI library to also connect to onecore voices. This should moreover simplify maintainability given the complexity induced by WinRT/C++ coding and build process.

Changes summary

Notes

Third party voices and tools like NaturalVoicesSAPIAdapter also rely on legacy SAPI to expose natural or online voices, as Microsoft does not officially provide documentation on how to install third party voices in Onecore voices set.

Also note that support of voices exposed by NaturalVoicesSAPIAdapter cannot be fully considered, given the following problems encountered while testing it with the fixes included by this PR :

bertfrees commented 2 months ago

@NPavie Nice work. Thank you! The is one issue with duplicate code. If that is fixed we can merge.

bertfrees commented 1 month ago

@NPavie Thanks!