search

daisy / pipeline-modules

Modules for the DAISY Pipeline project
4 stars 5 forks source link

word-to-dtbook: propagate change of pagination possible values #107

Closed NPavie closed 6 days ago

NPavie commented 1 week ago

@bertfrees A quick PR to propagate the change of pagination possible values of the script to the xslts.

bertfrees commented 1 week ago

@NPavie I wish you would have asked me about the bug first, before spending time on it. I had solved it differently, but for some reason it got lost in a rebase and it wasn't included in the 9f7c1b222d836fbd1ae989fae7691c049df3e613 commit.

Your solution is fine too of course.

bertfrees commented 1 week ago

Here is how I did it: https://github.com/daisy/pipeline/commit/2a498f9ac89b8ab1c57be604d81f1ee1e5422b5e

NPavie commented 1 week ago

I wish you would have asked me about the bug first, before spending time on it

It took me about 5 minutes , PR opening included, after checking the commits log so not much time lost here ^^

For the solution you propose, are you sure you want to keep 2 versions of the possible values between the xslts and the xproc script ? If we change the possible values' top definition, I personally prefer to propagate the change to avoid possible mismatch later.

bertfrees commented 6 days ago

It took me about 5 minutes

Hehe, OK then :-)

If we change the possible values' top definition, I personally prefer to propagate the change to avoid possible mismatch later.

OK sure.

bertfrees commented 6 days ago

Merged in 0b65d802 (fixed up and force-pushed).