search

daisy / pipeline-scripts

!! NOTE: This project is now part of the pipeline-modules project !! | Script modules for the default DAISY Pipeline 2 distribution.
GNU Lesser General Public License v3.0
6 stars 5 forks source link

dtbook to rtf #105

Closed YLBrailleNet closed 7 years ago

bertfrees commented 7 years ago

@YLBrailleNet I've finally reviewed your PR. It looked very good! I have added a few minor fixes, and added a XProcSpec test. The only other remark I have is that the "author" section only contains your name, but not the original author(s) of the Pipeline 1 script. Could you please add them?

(P.S.: note that I have rebased the branch)

YLBrailleNet commented 7 years ago

@bertfrees thanks for the remarks, i'll add that immediately.

bertfrees commented 7 years ago

Thanks. Oh and maybe a bit of explanation in the code for why the doc() function is being used?

bertfrees commented 7 years ago

@YLBrailleNet Is there some documentation for this script in Pipeline 1?

bertfrees commented 7 years ago

Merged in fc36ae398dd0d620d267b760c54a359e8065d345

See also